Skip to content

Cherry pick task navigation changes#28110

Closed
satender-kumar-collate wants to merge 10 commits into
open-metadata:1.12.8from
satender-kumar-collate:cherry_pick_task_navigation_changes
Closed

Cherry pick task navigation changes#28110
satender-kumar-collate wants to merge 10 commits into
open-metadata:1.12.8from
satender-kumar-collate:cherry_pick_task_navigation_changes

Conversation

@satender-kumar-collate
Copy link
Copy Markdown
Contributor

@satender-kumar-collate satender-kumar-collate commented May 14, 2026 •
edited by gitar-bot Bot
Loading

Describe your changes:

Fixes task navigation when user click on task from notifications

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Bug fix:
    • Resolved task navigation issues when accessing tasks via notification links.
  • Docker configuration:
    • Mirrored IBM iAccess driver on the Collate CDN to ensure build reliability.
  • Code style:
    • Applied black and isort formatting across Python files.
  • Security fix:
    • Removed client-supplied from field from thread and post creation to prevent unauthorized impersonation.

This will update automatically on new commits.

Satender and others added 8 commits May 14, 2026 14:33
fixed issue 27433
fe85a67
added E2E test case for issue 27433
32a1e29
@claude
fix(e2e): make task notification refresh test self-contained
e73df73 
Replace hardcoded 'raw_order' search with a test-owned TableClass entity,
remove fragile URL-splitting FQN extraction, and clean up the created task
in afterAll to prevent residual data across test runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude
style(e2e): apply prettier and import organization to TaskNavigation …
8deb7ff 
…spec

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
worked up comments by Rohit
921c403
updated test case as per review comment
b27ab42
added afterAll back as removing it will leave resources leaked in DB,…
4f90b13 
… as per GitAR
@claude
fix: remove client-supplied 'from' field from thread/post creation
f852c20 
The 'from' field was removed from createThread and createPost schemas as
a security fix — the server now derives the creator identity from the JWT
token. The schemas have additionalProperties:false, so the UI still
sending 'from' caused Jackson to reject every request with 400.

- Remove 'from' from createThread.json and createPost.json schemas
- Update generated TypeScript types (createThread.ts, createPost.ts)
- Drop 'from' from all POST payloads: ActivityFeedProvider, ActivityThreadPanelBody,
  AddAnnouncementModal, AnnouncementDrawer, and all four TasksPage create flows
- Fix getTaskData → getFeedData in ActivityFeedTab useEffect
- Remove unused useApplicationStore imports where currentUser is no longer needed
- Remove 'from' from Playwright API call in ActivityFeed.spec.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@satender-kumar-collate satender-kumar-collate requested a review from a team as a code owner May 14, 2026 09:53
@satender-kumar-collate satender-kumar-collate added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

⚠️ TypeScript Types Need Update

The generated TypeScript types are out of sync with the JSON schema changes.

Since this is a pull request from a forked repository, the types cannot be automatically committed.
Please generate and commit the types manually:

cd openmetadata-ui/src/main/resources/ui
./json2ts-generate-all.sh -l true
git add src/generated/
git commit -m "Update generated TypeScript types"
git push

After pushing the changes, this check will pass automatically.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Satender and others added 2 commits May 14, 2026 15:39
@claude
chore: regenerate TypeScript types from updated JSON schemas
6f4385c 
Regenerated after removing 'from' field from createThread and createPost
JSON schemas.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude
style: apply black and isort Python formatting
79a2838 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@satender-kumar-collate satender-kumar-collate requested a review from a team as a code owner May 14, 2026 10:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

❌ Playwright — ESLint + Prettier + Organise Imports

One or more Playwright test files have linting or formatting issues.

❌ Core Components — ESLint + Prettier

One or more core-component files have linting or formatting issues.

Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@satender-kumar-collate satender-kumar-collate deleted the cherry_pick_task_navigation_changes branch May 14, 2026 10:32
@satender-kumar-collate
Copy link
Copy Markdown
Contributor Author

satender-kumar-collate commented May 14, 2026

raising another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@satender-kumar-collate